Skip to content

Commit

Permalink
Remove unnecessary debugging from builtin-fetch
Browse files Browse the repository at this point in the history
The older git-fetch client did not produce all of this debugging
information to stdout.  Most end-users and Porcelain (e.g. StGIT,
git-gui, qgit) do not want to see these low-level details on the
console so they should be removed.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Shawn O. Pearce authored and Junio C Hamano committed Sep 19, 2007
1 parent 4ad1ead commit 133296f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
2 changes: 0 additions & 2 deletions builtin-fetch-pack.c
Original file line number Diff line number Diff line change
Expand Up @@ -767,8 +767,6 @@ struct ref *fetch_pack(const char *dest, int nr_heads, char **heads)
st.st_mtime = 0;
}

printf("connect to %s\n", dest);

pid = git_connect(fd, (char *)dest, uploadpack,
verbose ? CONNECT_VERBOSE : 0);
if (pid < 0)
Expand Down
9 changes: 0 additions & 9 deletions builtin-fetch.c
Original file line number Diff line number Diff line change
Expand Up @@ -370,15 +370,6 @@ static int do_fetch(struct transport *transport,
for (rm = ref_map; rm; rm = rm->next) {
if (rm->peer_ref)
read_ref(rm->peer_ref->name, rm->peer_ref->old_sha1);

printf("%s : %s\n", rm->name, rm->peer_ref ? rm->peer_ref->name : NULL);
printf(" < %s\n", sha1_to_hex(rm->old_sha1));
if (rm->peer_ref)
printf(" > %s\n", sha1_to_hex(rm->peer_ref->old_sha1));
if (!rm->peer_ref ||
hashcmp(rm->old_sha1, rm->peer_ref->old_sha1)) {
printf("%s needs update.\n", rm->name);
}
}

if (fetch_refs(transport, ref_map)) {
Expand Down

0 comments on commit 133296f

Please sign in to comment.