Skip to content

Commit

Permalink
strbuf.h: reorganize api function grouping headers
Browse files Browse the repository at this point in the history
The original API doc had something like:

    Functions
    ---------

    * Life cycle

      ... some life-cycle functions ...

    * Related to the contents of the buffer

      ... functions related to contents ....

    etc

This grouping can be hard to read in the comment sources,
given the "*" in the comment lines, and the amount of text
between each section.

Instead, let's make a flat list of groupings, and underline
each as a section header. That makes them stand out, and
eliminates the weird half-phrase of "Related to...". Like:

    Functions related to the contents of the buffer
    -----------------------------------------------

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Jan 16, 2015
1 parent 088c9a8 commit 14e2177
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions strbuf.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,8 @@ extern char strbuf_slopbuf[];
#define STRBUF_INIT { 0, 0, strbuf_slopbuf }

/**
* Functions
* ---------
*/

/**
* * Life Cycle
* Life Cycle Functions
* --------------------
*/

/**
Expand Down Expand Up @@ -120,7 +116,8 @@ static inline void strbuf_swap(struct strbuf *a, struct strbuf *b)


/**
* * Related to the size of the buffer
* Functions related to the size of the buffer
* -------------------------------------------
*/

/**
Expand Down Expand Up @@ -162,7 +159,8 @@ static inline void strbuf_setlen(struct strbuf *sb, size_t len)


/**
* * Related to the contents of the buffer
* Functions related to the contents of the buffer
* -----------------------------------------------
*/

/**
Expand Down Expand Up @@ -201,7 +199,8 @@ extern int strbuf_cmp(const struct strbuf *, const struct strbuf *);


/**
* * Adding data to the buffer
* Adding data to the buffer
* -------------------------
*
* NOTE: All of the functions in this section will grow the buffer as
* necessary. If they fail for some reason other than memory shortage and the
Expand Down

0 comments on commit 14e2177

Please sign in to comment.