Skip to content

Commit

Permalink
t/t9700/test.pl: don't access private object members, use public acce…
Browse files Browse the repository at this point in the history
…ss methods

This test is accessing private object members of the Test::More and
Test::Builder objects.  Older versions of Test::More did not implement
these variables using a hash.

My system complains as follows:

   Can't coerce array into hash at <snip>/t/t9700/test.pl line 13.
   BEGIN failed--compilation aborted at <snip>/t/t9700/test.pl line 15.

There are public access methods available for retrieving and setting these
variables, so let's use them instead.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Brandon Casey authored and Junio C Hamano committed Jun 29, 2010
1 parent 635155f commit 15eeb6e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions t/t9700/test.pl
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
BEGIN {
# t9700-perl-git.sh kicks off our testing, so we have to go from
# there.
Test::More->builder->{Curr_Test} = 1;
Test::More->builder->{No_Ending} = 1;
Test::More->builder->current_test(1);
Test::More->builder->no_ending(1);
}

use Cwd;
Expand Down Expand Up @@ -113,7 +113,7 @@ BEGIN
my $dir_commit = $r2->command_oneline('log', '-n1', '--pretty=format:%H', '.');
isnt($last_commit, $dir_commit, 'log . does not show last commit');

printf "1..%d\n", Test::More->builder->{Curr_Test};
printf "1..%d\n", Test::More->builder->current_test;

my $is_passing = eval { Test::More->is_passing };
exit($is_passing ? 0 : 1) unless $@ =~ /Can't locate object method/;

0 comments on commit 15eeb6e

Please sign in to comment.