Skip to content

Commit

Permalink
Use CVS's -f option if available (ignore user's ~/.cvsrc file)
Browse files Browse the repository at this point in the history
A user's ~/.cvsrc file can change the basic behavior of CVS commands.
Therefore we should ignore it in order to ensure consistent results
from the test suite.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Michael Haggerty authored and Junio C Hamano committed Feb 24, 2009
1 parent 535bb89 commit 161261b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
3 changes: 3 additions & 0 deletions t/lib-cvs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ then
exit
fi

CVS="cvs -f"
export CVS

cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps version //p'`
case "$cvsps_version" in
2.1 | 2.2*)
Expand Down
16 changes: 8 additions & 8 deletions t/t9600-cvsimport.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ test_description='git cvsimport basic tests'
CVSROOT=$(pwd)/cvsroot
export CVSROOT

test_expect_success 'setup cvsroot' 'cvs init'
test_expect_success 'setup cvsroot' '$CVS init'

test_expect_success 'setup a cvs module' '
mkdir "$CVSROOT/module" &&
cvs co -d module-cvs module &&
$CVS co -d module-cvs module &&
cd module-cvs &&
cat <<EOF >o_fortuna &&
O Fortuna
Expand All @@ -30,13 +30,13 @@ egestatem,
potestatem
dissolvit ut glaciem.
EOF
cvs add o_fortuna &&
$CVS add o_fortuna &&
cat <<EOF >message &&
add "O Fortuna" lyrics
These public domain lyrics make an excellent sample text.
EOF
cvs commit -F message &&
$CVS commit -F message &&
cd ..
'

Expand Down Expand Up @@ -74,7 +74,7 @@ translate to English
My Latin is terrible.
EOF
cvs commit -F message &&
$CVS commit -F message &&
cd ..
'

Expand All @@ -92,8 +92,8 @@ test_expect_success 'update cvs module' '
cd module-cvs &&
echo 1 >tick &&
cvs add tick &&
cvs commit -m 1
$CVS add tick &&
$CVS commit -m 1
cd ..
'
Expand All @@ -111,7 +111,7 @@ test_expect_success 'cvsimport.module config works' '

test_expect_success 'import from a CVS working tree' '
cvs co -d import-from-wt module &&
$CVS co -d import-from-wt module &&
cd import-from-wt &&
git cvsimport -a -z0 &&
echo 1 >expect &&
Expand Down

0 comments on commit 161261b

Please sign in to comment.