Skip to content

Commit

Permalink
git p4 test: wildcards are supported
Browse files Browse the repository at this point in the history
Since 9d57c4a (git p4: implement view spec wildcards with "p4
where", 2013-08-30), all the wildcard types should be supported.
Change must-fail tests to mark that they now pass.

Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Pete Wyckoff authored and Junio C Hamano committed Jan 21, 2014
1 parent feb28ad commit 1616898
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions t/t9809-git-p4-client-view.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,28 +76,28 @@ test_expect_success 'init depot' '
'

# double % for printf
test_expect_success 'unsupported view wildcard %%n' '
test_expect_success 'view wildcard %%n' '
client_view "//depot/%%%%1/sub/... //client/sub/%%%%1/..." &&
test_when_finished cleanup_git &&
test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
git p4 clone --use-client-spec --dest="$git" //depot
'

test_expect_success 'unsupported view wildcard *' '
test_expect_success 'view wildcard *' '
client_view "//depot/*/bar/... //client/*/bar/..." &&
test_when_finished cleanup_git &&
test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
git p4 clone --use-client-spec --dest="$git" //depot
'

test_expect_success 'wildcard ... only supported at end of spec 1' '
test_expect_success 'wildcard ... in the middle' '
client_view "//depot/.../file11 //client/.../file11" &&
test_when_finished cleanup_git &&
test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
git p4 clone --use-client-spec --dest="$git" //depot
'

test_expect_success 'wildcard ... only supported at end of spec 2' '
test_expect_success 'wildcard ... in the middle and at the end' '
client_view "//depot/.../a/... //client/.../a/..." &&
test_when_finished cleanup_git &&
test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
git p4 clone --use-client-spec --dest="$git" //depot
'

test_expect_success 'basic map' '
Expand Down

0 comments on commit 1616898

Please sign in to comment.