Skip to content

Commit

Permalink
Fix showing of path in tree view
Browse files Browse the repository at this point in the history
This patch fixes two things - links to all path elements except the last
one were broken since gitweb does not like the trailing slash in them, and
the root tree was not reachable from the subdirectory view.

To compensate for the one more slash in the front, the trailing slash is
not there anymore. ;-) I don't care if it stays there though.

Signed-off-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Petr Baudis authored and Junio C Hamano committed Sep 21, 2006
1 parent 053d62b commit 16fdb48
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions gitweb/gitweb.perl
Original file line number Diff line number Diff line change
Expand Up @@ -1514,12 +1514,15 @@ sub git_print_page_path {
my $fullname = '';

print "<div class=\"page_path\">";
print $cgi->a({-href => href(action=>"tree", hash_base=>$hb),
-title => '/'}, '/');
print " ";
foreach my $dir (@dirname) {
$fullname .= $dir . '/';
$fullname .= ($fullname ? '/' : '') . $dir;
print $cgi->a({-href => href(action=>"tree", file_name=>$fullname,
hash_base=>$hb),
-title => $fullname}, esc_html($dir));
print "/";
-title => $fullname}, esc_html($dir . '/'));
print " ";
}
if (defined $type && $type eq 'blob') {
print $cgi->a({-href => href(action=>"blob_plain", file_name=>$file_name,
Expand All @@ -1528,8 +1531,7 @@ sub git_print_page_path {
} elsif (defined $type && $type eq 'tree') {
print $cgi->a({-href => href(action=>"tree", file_name=>$file_name,
hash_base=>$hb),
-title => $name}, esc_html($basename));
print "/";
-title => $name}, esc_html($basename . '/'));
} else {
print esc_html($basename);
}
Expand Down

0 comments on commit 16fdb48

Please sign in to comment.