Skip to content

Commit

Permalink
[PATCH] Fix to how --merge-order handles multiple roots
Browse files Browse the repository at this point in the history
This patch addresses the problem reported by Paul Mackerras such that --merge-order
did not report the last root of a graph with merge of two independent roots.

Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jon Seymour authored and Linus Torvalds committed Jun 23, 2005
1 parent 6e4c0a5 commit 170774a
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions epoch.c
Original file line number Diff line number Diff line change
Expand Up @@ -488,16 +488,19 @@ static void sort_first_epoch(struct commit *head, struct commit_list **stack)
*
* Sets the return value to STOP if no further output should be generated.
*/
static int emit_stack(struct commit_list **stack, emitter_func emitter)
static int emit_stack(struct commit_list **stack, emitter_func emitter, int include_last)
{
unsigned int seen = 0;
int action = CONTINUE;

while (*stack && (action != STOP)) {
struct commit *next = pop_commit(stack);
seen |= next->object.flags;
if (*stack)
if (*stack || include_last) {
if (!*stack)
next->object.flags |= BOUNDARY;
action = (*emitter) (next);
}
}

if (*stack) {
Expand Down Expand Up @@ -553,7 +556,7 @@ static int sort_in_merge_order(struct commit *head_of_epoch, emitter_func emitte
} else {
struct commit_list *stack = NULL;
sort_first_epoch(next, &stack);
action = emit_stack(&stack, emitter);
action = emit_stack(&stack, emitter, (base == NULL));
next = base;
}
}
Expand Down Expand Up @@ -636,7 +639,7 @@ int sort_list_in_merge_order(struct commit_list *list, emitter_func emitter)
}
}

action = emit_stack(&stack, emitter);
action = emit_stack(&stack, emitter, (base==NULL));
}

if (base && (action != STOP)) {
Expand Down

0 comments on commit 170774a

Please sign in to comment.