Skip to content

Commit

Permalink
tests: drop GIT_*_TIMING_TESTS environment variable support
Browse files Browse the repository at this point in the history
Two tests (t3302 and t3419) used to have their own environment
variable to trigger expensive tests without enabling expensive
tests in other scripts; a user could set GIT_NOTES_TIMING_TESTS
but not GIT_TEST_LONG and run the whole test suite and trigger
expensive tests only in t3302 but not other tests.  The same for
GIT_PATCHID_TIMING_TESTS in t3419.

While this may have seemed a good flexibility, in reality if you are
concentrating on a single test (e.g. t3302), you can just run that
single test with the GIT_TEST_LONG to trigger expensive tests.  It
does not seem worth forcing other people who may want to come up
with their own expensive tests to invent new environment variables
by keeping this convention.

Drop them.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Jun 13, 2014
1 parent b687cd6 commit 1bb207e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions t/t3302-notes-index-expensive.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ test_description='Test commit notes index (expensive!)'

. ./test-lib.sh

test -n "$GIT_NOTES_TIMING_TESTS" && test_set_prereq EXPENSIVE

create_repo () {
number_of_commits=$1
nr=0
Expand Down
2 changes: 0 additions & 2 deletions t/t3419-rebase-patch-id.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ test_description='git rebase - test patch id computation'

. ./test-lib.sh

test -n "$GIT_PATCHID_TIMING_TESTS" && test_set_prereq EXPENSIVE

count () {
i=0
while test $i -lt $1
Expand Down

0 comments on commit 1bb207e

Please sign in to comment.