Skip to content

Commit

Permalink
git-gui: Don't kill modified commit message buffer with merge templates
Browse files Browse the repository at this point in the history
If the user is in the middle of a merge and has already started to
modify their commit message we were losing the user's changes when
they pressed 'Rescan' after resolving issues or making changes in
the working directory.

The problem here was our background timer that saves the commit
message buffer.  It marks the commit message buffer as not being
modified when it writes it out to disk, so during the rescan we
assumed the buffer should be replaced with what we read from the
MERGE_MSG file.  So we now only read these files from .git if we
have a valid backup file.  Since we clear it on commit this will
only have an impact while the user is actively editing the current
commit.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
Shawn O. Pearce committed Jul 27, 2007
1 parent bc318ea commit 1e0a92f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions git-gui.sh
Original file line number Diff line number Diff line change
Expand Up @@ -829,8 +829,9 @@ proc rescan {after {honor_trustmtime 1}} {

array unset file_states

if {![$ui_comm edit modified]
|| [string trim [$ui_comm get 0.0 end]] eq {}} {
if {!$::GITGUI_BCK_exists &&
(![$ui_comm edit modified]
|| [string trim [$ui_comm get 0.0 end]] eq {})} {
if {[string match amend* $commit_type]} {
} elseif {[load_message GITGUI_MSG]} {
} elseif {[load_message MERGE_MSG]} {
Expand Down

0 comments on commit 1e0a92f

Please sign in to comment.