Skip to content

Commit

Permalink
t7405: cd inside subshell instead of around
Browse files Browse the repository at this point in the history
Instead of using `cd dir && (...) && cd..` use `(cd dir && ...)`

This ensures that the test doesn't get caught in the subdirectory if there
is an error in the subshell.

Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jens Lehmann authored and Junio C Hamano committed Sep 3, 2010
1 parent b49c452 commit 1e28476
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions t/t7405-submodule-merge.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ test_expect_success setup '
# b in the main repository.
test_expect_success 'setup for merge search' '
mkdir merge-search &&
cd merge-search &&
(cd merge-search &&
git init &&
mkdir sub &&
(cd sub &&
Expand Down Expand Up @@ -101,8 +101,7 @@ test_expect_success 'setup for merge search' '
git checkout -b sub-d sub-b &&
git merge sub-c) &&
git commit -a -m "d" &&
git branch test b &&
cd ..
git branch test b)
'

test_expect_success 'merge with one side as a fast-forward of the other' '
Expand All @@ -126,7 +125,7 @@ test_expect_success 'merging should conflict for non fast-forward' '
'

test_expect_success 'merging should fail for ambiguous common parent' '
cd merge-search &&
(cd merge-search &&
git checkout -b test-ambiguous b &&
(cd sub &&
git checkout -b ambiguous sub-b &&
Expand All @@ -136,8 +135,7 @@ test_expect_success 'merging should fail for ambiguous common parent' '
test_must_fail git merge c 2> actual &&
grep $(cat expect1) actual > /dev/null &&
grep $(cat expect2) actual > /dev/null &&
git reset --hard &&
cd ..
git reset --hard)
'

# in a situation like this
Expand All @@ -158,7 +156,7 @@ test_expect_success 'merging should fail for ambiguous common parent' '
# commits (sub-a) does not descend from the submodule merge-base (sub-b).
#
test_expect_success 'merging should fail for changes that are backwards' '
cd merge-search &&
(cd merge-search &&
git checkout -b bb a &&
(cd sub &&
git checkout sub-b) &&
Expand All @@ -175,16 +173,13 @@ test_expect_success 'merging should fail for changes that are backwards' '
git commit -a -m "f" &&
git checkout -b test-backward e &&
test_must_fail git merge f &&
cd ..
test_must_fail git merge f)
'

test_expect_success 'merging with a modify/modify conflict between merge bases' '
git reset --hard HEAD &&
git checkout -b test2 c &&
git merge d
'

test_done

0 comments on commit 1e28476

Please sign in to comment.