Skip to content

Commit

Permalink
git-svn: do not let Git.pm warn if we prematurely close pipes
Browse files Browse the repository at this point in the history
This mainly quiets down warnings when running git svn log.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Eric Wong authored and Junio C Hamano committed Feb 2, 2007
1 parent 1e5db30 commit 22600a2
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions git-svn.perl
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ sub show_log {
process_commit($_, $r_min, $r_max) foreach reverse @k;
}
out:
eval { command_close_pipe($log) };
close $log;
print '-' x72,"\n" unless $_incremental || $_oneline;
}

Expand Down Expand Up @@ -1475,7 +1475,7 @@ sub map_tree_joins {
$seen{$commit} = 1;
}
}
eval { command_close_pipe($pipe) };
close $pipe;
}
}

Expand Down Expand Up @@ -1669,7 +1669,7 @@ sub write_grafts {
last unless /^\S/;
}
}
eval { command_close_pipe($ch) }; # breaking the pipe
close $ch; # breaking the pipe

# if real parents are the only ones in the grafts, drop it
next if join(' ',sort keys %$p) eq join(' ',sort keys %x);
Expand Down Expand Up @@ -1766,7 +1766,7 @@ sub get_commit_time {
} elsif ($tz =~ s/^\-//) {
$s -= tz_to_s_offset($tz);
}
eval { command_close_pipe($fh) };
close $fh;
return $s;
}
die "Can't get commit time for commit: $cmt\n";
Expand Down Expand Up @@ -2846,7 +2846,7 @@ sub rmdirs {
delete $rm->{join '/', @dn};
}
unless (%$rm) {
eval { command_close_pipe($fh) };
close $fh;
return;
}
}
Expand Down

0 comments on commit 22600a2

Please sign in to comment.