Skip to content

Commit

Permalink
t3600-rm: skip failed-remove test when we cannot make an unremovable …
Browse files Browse the repository at this point in the history
…file.

When running t3600-rm test under fakeroot (or as root), we
cannot make a file unremovable with "chmod a-w .".  Detect this
case early and skip that test.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed Apr 13, 2006
1 parent f43ba60 commit 2283645
Showing 1 changed file with 15 additions and 3 deletions.
18 changes: 15 additions & 3 deletions t/t3600-rm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@ else
test_tabs=n
fi

# Later we will try removing an unremovable path to make sure
# git-rm barfs, but if the test is run as root that cannot be
# arranged.
: >test-file
chmod a-w .
rm -f test-file
test -f test-file && test_failed_remove=y
chmod 775 .
rm -f test-file

test_expect_success \
'Pre-check that foo exists and is in index before git-rm foo' \
'[ -f foo ] && git-ls-files --error-unmatch foo'
Expand Down Expand Up @@ -56,12 +66,14 @@ test "$test_tabs" = y && test_expect_success \
"git-rm -f 'space embedded' 'tab embedded' 'newline
embedded'"

if test "$test_tabs" = y; then
chmod u-w .
if test "$test_failed_remove" = y; then
chmod a-w .
test_expect_failure \
'Test that "git-rm -f" fails if its rm fails' \
'git-rm -f baz'
chmod u+w .
chmod 775 .
else
test_expect_success 'skipping removal failure (perhaps running as root?)' :
fi

test_expect_success \
Expand Down

0 comments on commit 2283645

Please sign in to comment.