Skip to content

Commit

Permalink
t0024, t5000: use test_lazy_prereq for UNZIP
Browse files Browse the repository at this point in the history
This change makes the code smaller and we can put it at the top of
the script, its rightful place as setup code.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
René Scharfe authored and Junio C Hamano committed Jan 7, 2013
1 parent ac00128 commit 25d3d32
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 14 deletions.
12 changes: 5 additions & 7 deletions t/t0024-crlf-archive.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ test_description='respect crlf in git archive'
. ./test-lib.sh
GIT_UNZIP=${GIT_UNZIP:-unzip}

test_lazy_prereq UNZIP '
"$GIT_UNZIP" -v
test $? -ne 127
'

test_expect_success setup '
git config core.autocrlf true &&
Expand All @@ -26,13 +31,6 @@ test_expect_success 'tar archive' '
'

"$GIT_UNZIP" -v >/dev/null 2>&1
if [ $? -eq 127 ]; then
say "Skipping ZIP test, because unzip was not found"
else
test_set_prereq UNZIP
fi

test_expect_success UNZIP 'zip archive' '
git archive --format=zip HEAD >test.zip &&
Expand Down
12 changes: 5 additions & 7 deletions t/t5000-tar-tree.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ GUNZIP=${GUNZIP:-gzip -d}

SUBSTFORMAT=%H%n

test_lazy_prereq UNZIP '
"$GIT_UNZIP" -v
test $? -ne 127
'

check_zip() {
zipfile=$1.zip
listfile=$1.lst
Expand Down Expand Up @@ -201,13 +206,6 @@ test_expect_success \
test_cmp a/substfile2 g/prefix/a/substfile2
'

"$GIT_UNZIP" -v >/dev/null 2>&1
if [ $? -eq 127 ]; then
say "Skipping ZIP tests, because unzip was not found"
else
test_set_prereq UNZIP
fi

test_expect_success \
'git archive --format=zip' \
'git archive --format=zip HEAD >d.zip'
Expand Down

0 comments on commit 25d3d32

Please sign in to comment.