Skip to content

Commit

Permalink
git-send-email: Fully implement --quiet and document it.
Browse files Browse the repository at this point in the history
Also reorganizes the man page to list options alphabetically.

Signed-off-by: Ryan Anderson <ryan@michonline.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Ryan Anderson authored and Junio C Hamano committed Feb 6, 2006
1 parent df9892f commit 2718435
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 26 deletions.
44 changes: 24 additions & 20 deletions Documentation/git-send-email.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,44 +24,48 @@ OPTIONS
-------
The options available are:

--to::
Specify the primary recipient of the emails generated.
Generally, this will be the upstream maintainer of the
project involved.
--chain-reply-to, --no-chain-reply-to::
If this is set, each email will be sent as a reply to the previous
email sent. If disabled with "--no-chain-reply-to", all emails after
the first will be sent as replies to the first email sent. When using
this, it is recommended that the first file given be an overview of the
entire patch series.
Default is --chain-reply-to

--compose::
Use $EDITOR to edit an introductory message for the
patch series.

--from::
Specify the sender of the emails. This will default to
the value GIT_COMMITTER_IDENT, as returned by "git-var -l".
The user will still be prompted to confirm this entry.

--compose::
Use \$EDITOR to edit an introductory message for the
patch series.

--subject::
Specify the initial subject of the email thread.
Only necessary if --compose is also set. If --compose
is not set, this will be prompted for.

--in-reply-to::
Specify the contents of the first In-Reply-To header.
Subsequent emails will refer to the previous email
instead of this if --chain-reply-to is set (the default)
Only necessary if --compose is also set. If --compose
is not set, this will be prompted for.

--chain-reply-to, --no-chain-reply-to::
If this is set, each email will be sent as a reply to the previous
email sent. If disabled with "--no-chain-reply-to", all emails after
the first will be sent as replies to the first email sent. When using
this, it is recommended that the first file given be an overview of the
entire patch series.
Default is --chain-reply-to
--quiet::
Make git-send-email less verbose. One line per email should be
all that is output.

--smtp-server::
If set, specifies the outgoing SMTP server to use. Defaults to
localhost.

--subject::
Specify the initial subject of the email thread.
Only necessary if --compose is also set. If --compose
is not set, this will be prompted for.

--to::
Specify the primary recipient of the emails generated.
Generally, this will be the upstream maintainer of the
project involved.


Author
------
Expand Down
19 changes: 13 additions & 6 deletions git-send-email.perl
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@
}

if (@files) {
print $_,"\n" for @files;
unless ($quiet) {
print $_,"\n" for (@files);
}
} else {
print <<EOT;
git-send-email [options] <file | directory> [... file | directory ]
Expand All @@ -213,6 +215,10 @@
--smtp-server If set, specifies the outgoing SMTP server to use.
Defaults to localhost.
--quiet Make git-send-email less verbose. One line per email should be
all that is output.
Error: Please specify a file or a directory on the command line.
EOT
exit(1);
Expand Down Expand Up @@ -268,7 +274,9 @@ sub send_message

sendmail(%mail) or die $Mail::Sendmail::error;

unless ($quiet) {
if ($quiet) {
printf "Sent %s\n", $subject;
} else {
print "OK. Log says:\n", $Mail::Sendmail::log;
print "\n\n"
}
Expand All @@ -280,7 +288,6 @@ sub send_message
$subject = $initial_subject;

foreach my $t (@files) {
my $F = $t;
open(F,"<",$t) or die "can't open file $t";

@cc = ();
Expand All @@ -298,7 +305,7 @@ sub send_message

} elsif (/^(Cc|From):\s+(.*)$/) {
printf("(mbox) Adding cc: %s from line '%s'\n",
$2, $_);
$2, $_) unless $quiet;
push @cc, $2;
}

Expand All @@ -310,7 +317,7 @@ sub send_message
# So let's support that, too.
if (@cc == 0) {
printf("(non-mbox) Adding cc: %s from line '%s'\n",
$_, $_);
$_, $_) unless $quiet;

push @cc, $_;

Expand All @@ -330,7 +337,7 @@ sub send_message
chomp $c;
push @cc, $c;
printf("(sob) Adding cc: %s from line '%s'\n",
$c, $_);
$c, $_) unless $quiet;
}
}
}
Expand Down

0 comments on commit 2718435

Please sign in to comment.