Skip to content

Commit

Permalink
Fall back to $EMAIL for missing GIT_AUTHOR_EMAIL and GIT_COMMITTER_EMAIL
Browse files Browse the repository at this point in the history
Some other programs get the user's email address from $EMAIL, so fall back to
that if we don't have a Git-specific email address.

Signed-off-by: Josh Triplett <josh@freedesktop.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Josh Triplett authored and Junio C Hamano committed Apr 29, 2007
1 parent 25dc5e2 commit 28a94f8
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Documentation/config.txt
Original file line number Diff line number Diff line change
Expand Up @@ -610,8 +610,8 @@ tar.umask::

user.email::
Your email address to be recorded in any newly created commits.
Can be overridden by the 'GIT_AUTHOR_EMAIL' and 'GIT_COMMITTER_EMAIL'
environment variables. See gitlink:git-commit-tree[1].
Can be overridden by the 'GIT_AUTHOR_EMAIL', 'GIT_COMMITTER_EMAIL', and
'EMAIL' environment variables. See gitlink:git-commit-tree[1].

user.name::
Your full name to be recorded in any newly created commits.
Expand Down
1 change: 1 addition & 0 deletions Documentation/git-commit-tree.txt
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ either `.git/config` file, or using the following environment variables.
GIT_COMMITTER_NAME
GIT_COMMITTER_EMAIL
GIT_COMMITTER_DATE
EMAIL

(nb "<", ">" and "\n"s are stripped)

Expand Down
1 change: 1 addition & 0 deletions Documentation/git.txt
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ git Commits
'GIT_COMMITTER_NAME'::
'GIT_COMMITTER_EMAIL'::
'GIT_COMMITTER_DATE'::
'EMAIL'::
see gitlink:git-commit-tree[1]

git Diffs
Expand Down
2 changes: 2 additions & 0 deletions ident.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ const char *fmt_ident(const char *name, const char *email,
setup_ident();
if (!name)
name = git_default_name;
if (!email)
email = getenv("EMAIL");
if (!email)
email = git_default_email;

Expand Down
1 change: 1 addition & 0 deletions t/test-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ unset AUTHOR_EMAIL
unset AUTHOR_NAME
unset COMMIT_AUTHOR_EMAIL
unset COMMIT_AUTHOR_NAME
unset EMAIL
unset GIT_ALTERNATE_OBJECT_DIRECTORIES
unset GIT_AUTHOR_DATE
GIT_AUTHOR_EMAIL=author@example.com
Expand Down

0 comments on commit 28a94f8

Please sign in to comment.