Skip to content

Commit

Permalink
gitk: fix tabbed preferences construction when using tcl 8.4
Browse files Browse the repository at this point in the history
In 8.5 the incr command creates the target variable if it does not exist
but in 8.4 using incr on a non-existing variable raises an error. Ensure
we have created our counter variable when creating the tabbed dialog for
non-themed preferences.

Reported-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Pat Thoyts authored and Junio C Hamano committed Apr 2, 2012
1 parent b2b76d1 commit 28cb707
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions gitk
Original file line number Diff line number Diff line change
Expand Up @@ -11012,6 +11012,7 @@ proc doprefs {} {
lappend pages [prefspage_general $notebook] [mc "General"]
lappend pages [prefspage_colors $notebook] [mc "Colors"]
lappend pages [prefspage_fonts $notebook] [mc "Fonts"]
set col 0
foreach {page title} $pages {
if {$use_notebook} {
$notebook add $page -text $title
Expand Down

0 comments on commit 28cb707

Please sign in to comment.