Skip to content

Commit

Permalink
rm: convert to use parse_pathspec
Browse files Browse the repository at this point in the history
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Nguyễn Thái Ngọc Duy authored and Junio C Hamano committed Jul 15, 2013
1 parent 817b345 commit 29211a9
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions builtin/rm.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include "parse-options.h"
#include "string-list.h"
#include "submodule.h"
#include "pathspec.h"

static const char * const builtin_rm_usage[] = {
N_("git rm [options] [--] <file>..."),
Expand Down Expand Up @@ -279,7 +280,7 @@ static struct option builtin_rm_options[] = {
int cmd_rm(int argc, const char **argv, const char *prefix)
{
int i, newfd;
const char **pathspec;
struct pathspec pathspec;
char *seen;

git_config(git_default_config, NULL);
Expand Down Expand Up @@ -312,39 +313,38 @@ int cmd_rm(int argc, const char **argv, const char *prefix)
}
}

pathspec = get_pathspec(prefix, argv);
refresh_index(&the_index, REFRESH_QUIET, pathspec, NULL, NULL);
parse_pathspec(&pathspec, 0, PATHSPEC_PREFER_CWD, prefix, argv);
refresh_index(&the_index, REFRESH_QUIET, pathspec.raw, NULL, NULL);

seen = NULL;
for (i = 0; pathspec[i] ; i++)
/* nothing */;
seen = xcalloc(i, 1);
seen = xcalloc(pathspec.nr, 1);

for (i = 0; i < active_nr; i++) {
struct cache_entry *ce = active_cache[i];
if (!match_pathspec(pathspec, ce->name, ce_namelen(ce), 0, seen))
if (!match_pathspec_depth(&pathspec, ce->name, ce_namelen(ce), 0, seen))
continue;
ALLOC_GROW(list.entry, list.nr + 1, list.alloc);
list.entry[list.nr].name = ce->name;
list.entry[list.nr++].is_submodule = S_ISGITLINK(ce->ce_mode);
}

if (pathspec) {
const char *match;
if (pathspec.nr) {
const char *original;
int seen_any = 0;
for (i = 0; (match = pathspec[i]) != NULL ; i++) {
for (i = 0; i < pathspec.nr; i++) {
original = pathspec.items[i].original;
if (!seen[i]) {
if (!ignore_unmatch) {
die(_("pathspec '%s' did not match any files"),
match);
original);
}
}
else {
seen_any = 1;
}
if (!recursive && seen[i] == MATCHED_RECURSIVELY)
die(_("not removing '%s' recursively without -r"),
*match ? match : ".");
*original ? original : ".");
}

if (! seen_any)
Expand Down

0 comments on commit 29211a9

Please sign in to comment.