Skip to content

Commit

Permalink
git-rebase--interactive.sh: Don't pass a strategy to git-cherry-pick.
Browse files Browse the repository at this point in the history
git-cherry-pick doesn't support a strategy paramter, so don't pass one.
This means that --strategy for interactive rebases is a no-op for
anything but merge commits, but that's still better than being broken. A
correct fix would probably need to port the --merge behaviour from plain
git-rebase.sh, but I have no clue how to integrate that cleanly.

Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Björn Steinbrink authored and Junio C Hamano committed Oct 31, 2007
1 parent 3524b28 commit 2a9c53e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions git-rebase--interactive.sh
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ pick_one () {
sha1=$(git rev-parse --short $sha1)
output warn Fast forward to $sha1
else
output git cherry-pick $STRATEGY "$@"
output git cherry-pick "$@"
fi
}

Expand Down Expand Up @@ -173,7 +173,7 @@ pick_one_preserving_merges () {
fi
;;
*)
output git cherry-pick $STRATEGY "$@" ||
output git cherry-pick "$@" ||
die_with_patch $sha1 "Could not pick $sha1"
esac
esac
Expand Down

0 comments on commit 2a9c53e

Please sign in to comment.