Skip to content

Commit

Permalink
[PATCH] Adjust diff-helper to diff-tree -v -z changes.
Browse files Browse the repository at this point in the history
The latest change to diff-tree -z output adds an extra line
termination after non diff-raw material (the header and the
commit message).  To compensate for this change, stop adding the
output termination of our own.  "diff-tree -v -z" piped to
"diff-helper -z" would give different result from "diff-tree -v"
piped to "diff-helper" without this change.

Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Junio C Hamano authored and Linus Torvalds committed May 29, 2005
1 parent f0c6b2a commit 2bc2564
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion diff-helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ static const char *diff_helper_usage =

int main(int ac, const char **av) {
struct strbuf sb;
const char *garbage_flush_format;

strbuf_init(&sb);

Expand All @@ -30,6 +31,8 @@ int main(int ac, const char **av) {
usage(diff_helper_usage);
ac--; av++;
}
garbage_flush_format = (line_termination == 0) ? "%s" : "%s\n";

/* the remaining parameters are paths patterns */

diff_setup(0);
Expand Down Expand Up @@ -134,7 +137,7 @@ int main(int ac, const char **av) {
if (pickaxe)
diffcore_pickaxe(pickaxe, pickaxe_opts);
diff_flush(DIFF_FORMAT_PATCH, 0);
printf("%s\n", sb.buf);
printf(garbage_flush_format, sb.buf);
}
if (1 < ac)
diffcore_pathspec(av + 1);
Expand Down

0 comments on commit 2bc2564

Please sign in to comment.