Skip to content

Commit

Permalink
Make test-path-utils more robust against incorrect use
Browse files Browse the repository at this point in the history
Previously, this test utility happily returned with exit code 0 if garbage
was thrown at it. Now it reports failure if an unknown function name was
given on the command line.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Johannes Sixt authored and Junio C Hamano committed Feb 7, 2009
1 parent ab2fdb3 commit 2cd85c4
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion test-path-utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ int main(int argc, char **argv)
int rv = normalize_absolute_path(buf, argv[2]);
assert(strlen(buf) == rv);
puts(buf);
return 0;
}

if (argc >= 2 && !strcmp(argv[1], "make_absolute_path")) {
Expand All @@ -15,12 +16,16 @@ int main(int argc, char **argv)
argc--;
argv++;
}
return 0;
}

if (argc == 4 && !strcmp(argv[1], "longest_ancestor_length")) {
int len = longest_ancestor_length(argv[2], argv[3]);
printf("%d\n", len);
return 0;
}

return 0;
fprintf(stderr, "%s: unknown function name: %s\n", argv[0],
argv[1] ? argv[1] : "(there was none)");
return 1;
}

0 comments on commit 2cd85c4

Please sign in to comment.