Skip to content

Commit

Permalink
git-gui: Tighten internal pattern match for lib/ directory
Browse files Browse the repository at this point in the history
Our GITGUI_LIBDIR macro was testing only for @@ at the start of
the path, assuming nobody would ever find that to be a reasonable
prefix for a directory to install our library into.  That is most
likely a valid assumption, but its even more unlikely they would
have the start be @@GITGUI_ and the end be @@.  Note that we
cannot use the full string here because that would get expanded
by the sed replacement in our Makefile.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
Shawn O. Pearce committed May 22, 2007
1 parent b9e7efb commit 306fc12
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion git-gui.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA}
## configure our library

set oguilib {@@GITGUI_LIBDIR@@}
if {[string match @@* $oguilib]} {
if {[string match @@GITGUI_*@@ $oguilib]} {
set oguilib [file join [file dirname [file normalize $argv0]] lib]
}
set idx [file join $oguilib tclIndex]
Expand Down

0 comments on commit 306fc12

Please sign in to comment.