Skip to content

Commit

Permalink
for-each-ref: "creator" and "creatordate" fields
Browse files Browse the repository at this point in the history
This adds "creator" (which is parallel to "tagger" or "committer")
and "creatordate" (corresponds to "taggerdate" and
"committerdate").

As other "date" fields, "creatordate" sorts numerically
and displays human readably. This allows for example for
sorting together heavyweigth and lightweight tags.

Signed-off-by: Junio C Hamano <junkio@cox.net>
Acked-by: Jakub Narebski <jnareb@gmail.com>
  • Loading branch information
Junio C Hamano committed Nov 3, 2006
1 parent 34eb334 commit 3175aa1
Showing 1 changed file with 25 additions and 0 deletions.
25 changes: 25 additions & 0 deletions builtin-for-each-ref.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ static struct {
{ "taggername" },
{ "taggeremail" },
{ "taggerdate", FIELD_TIME },
{ "creator" },
{ "creatordate", FIELD_TIME },
{ "subject" },
{ "body" },
{ "contents" },
Expand Down Expand Up @@ -401,6 +403,29 @@ static void grab_person(const char *who, struct atom_value *val, int deref, stru
else if (!strcmp(name + wholen, "date"))
grab_date(wholine, v);
}

/* For a tag or a commit object, if "creator" or "creatordate" is
* requested, do something special.
*/
if (strcmp(who, "tagger") && strcmp(who, "committer"))
return; /* "author" for commit object is not wanted */
if (!wholine)
wholine = find_wholine(who, wholen, buf, sz);
if (!wholine)
return;
for (i = 0; i < used_atom_cnt; i++) {
const char *name = used_atom[i];
struct atom_value *v = &val[i];
if (!!deref != (*name == '*'))
continue;
if (deref)
name++;

if (!strcmp(name, "creatordate"))
grab_date(wholine, v);
else if (!strcmp(name, "creator"))
v->s = copy_line(wholine);
}
}

static void find_subpos(const char *buf, unsigned long sz, const char **sub, const char **body)
Expand Down

0 comments on commit 3175aa1

Please sign in to comment.