Skip to content

Commit

Permalink
refs: plug strbuf leak in lock_ref_sha1_basic()
Browse files Browse the repository at this point in the history
Don't just reset, but release the resource held by the local
variable that is about to go out of scope.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
René Scharfe authored and Junio C Hamano committed Dec 29, 2014
1 parent bbcefff commit 33adc83
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion refs.c
Original file line number Diff line number Diff line change
Expand Up @@ -2334,7 +2334,7 @@ static struct ref_lock *lock_ref_sha1_basic(const char *refname,
struct strbuf err = STRBUF_INIT;
unable_to_lock_message(ref_file, errno, &err);
error("%s", err.buf);
strbuf_reset(&err);
strbuf_release(&err);
goto error_return;
}
}
Expand Down

0 comments on commit 33adc83

Please sign in to comment.