Skip to content

Commit

Permalink
git-log produces no output
Browse files Browse the repository at this point in the history
When $PAGER is set to 'less -i', we used to fail because we
assumed the $PAGER is a command and simply exec'ed it.

Try exec first, and then run it through shell if it fails.  This
allows even funkier PAGERs like these ;-):

	PAGER='sed -e "s/^/`date`: /" | more'
	PAGER='contrib/colordiff.perl | less -RS'

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Linus Torvalds authored and Junio C Hamano committed Apr 21, 2006
1 parent 0dec30b commit 34fd1c9
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pager.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
static void run_pager(const char *pager)
{
execlp(pager, pager, NULL);
execl("/bin/sh", "sh", "-c", pager, NULL);
}

void setup_pager(void)
Expand Down Expand Up @@ -47,5 +48,6 @@ void setup_pager(void)

setenv("LESS", "-S", 0);
run_pager(pager);
die("unable to execute pager '%s'", pager);
exit(255);
}

0 comments on commit 34fd1c9

Please sign in to comment.