Skip to content

Commit

Permalink
git-p4: Change p4 command invocation
Browse files Browse the repository at this point in the history
Change p4 command invocation to avoid going through the shell. This
allows names with spaces and wildcards to work.

Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Vitor Antunes <vitor.hda@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Pete Wyckoff authored and Junio C Hamano committed Jan 26, 2012
1 parent c5665ef commit 3558f32
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion contrib/fast-import/git-p4
Original file line number Diff line number Diff line change
Expand Up @@ -1984,7 +1984,7 @@ class P4Sync(Command, P4UserMap):
def importChanges(self, changes):
cnt = 1
for change in changes:
description = p4Cmd("describe %s" % change)
description = p4Cmd(["describe", str(change)])
self.updateOptionDict(description)

if not self.silent:
Expand Down

0 comments on commit 3558f32

Please sign in to comment.