Skip to content

Commit

Permalink
Merge branch 'jg/prompt-localize-temporary'
Browse files Browse the repository at this point in the history
"git-prompt" (in contrib/) used a variable from the global scope,
possibly contaminating end-user's namespace.

* jg/prompt-localize-temporary:
  git-prompt.sh: make $f local to __git_eread()
  • Loading branch information
Junio C Hamano committed Dec 22, 2014
2 parents 3d4eecc + 9dd70e0 commit 35b5a8b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion contrib/completion/git-prompt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ __git_ps1_colorize_gitstring ()

__git_eread ()
{
f="$1"
local f="$1"
shift
test -r "$f" && read "$@" <"$f"
}
Expand Down

0 comments on commit 35b5a8b

Please sign in to comment.