Skip to content

Commit

Permalink
Merge branch 'jn/test-lint-unmoor'
Browse files Browse the repository at this point in the history
* jn/test-lint-unmoor:
  test-lint: find unportable sed, echo, test, and export usage after &&
  • Loading branch information
Junio C Hamano committed Jun 6, 2014
2 parents 3ea8ecc + 561b46c commit 3784ba3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions t/check-non-portable-shell.pl
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ sub err {

while (<>) {
chomp;
/^\s*sed\s+-i/ and err 'sed -i is not portable';
/^\s*echo\s+-n/ and err 'echo -n is not portable (please use printf)';
/\bsed\s+-i/ and err 'sed -i is not portable';
/\becho\s+-n/ and err 'echo -n is not portable (please use printf)';
/^\s*declare\s+/ and err 'arrays/declare not portable';
/^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
/test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
/^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';
/\btest\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
/\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';
# this resets our $. for each file
close ARGV if eof;
}
Expand Down

0 comments on commit 3784ba3

Please sign in to comment.