Skip to content

Commit

Permalink
interpret_nth_last_branch(): plug small memleak
Browse files Browse the repository at this point in the history
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Jan 20, 2009
1 parent c829774 commit 39765e5
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions sha1_name.c
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ static int grab_nth_branch_switch(unsigned char *osha1, unsigned char *nsha1,
int interpret_nth_last_branch(const char *name, struct strbuf *buf)
{
long nth;
int i;
int i, retval;
struct grab_nth_branch_switch_cbdata cb;
const char *brace;
char *num_end;
Expand All @@ -774,17 +774,21 @@ int interpret_nth_last_branch(const char *name, struct strbuf *buf)
for (i = 0; i < nth; i++)
strbuf_init(&cb.buf[i], 20);
cb.cnt = 0;
retval = 0;
for_each_reflog_ent("HEAD", grab_nth_branch_switch, &cb);
if (cb.cnt < nth)
return 0;
goto release_return;
i = cb.cnt % nth;
strbuf_reset(buf);
strbuf_add(buf, cb.buf[i].buf, cb.buf[i].len);
retval = brace-name+1;

release_return:
for (i = 0; i < nth; i++)
strbuf_release(&cb.buf[i]);
free(cb.buf);

return brace-name+1;
return retval;
}

/*
Expand Down

0 comments on commit 39765e5

Please sign in to comment.