Skip to content

Commit

Permalink
http: re-word http error message
Browse files Browse the repository at this point in the history
When we report an http error code, we say something like:

  error: The requested URL reported failure: 403 Forbidden while accessing http://example.com/repo.git

Everything between "error:" and "while" is written by curl,
and the resulting sentence is hard to read (especially
because there is no punctuation between curl's sentence and
the remainder of ours). Instead, let's re-order this to give
better flow:

  error: unable to access 'http://example.com/repo.git: The requested URL reported failure: 403 Forbidden

This is still annoyingly long, but at least reads more
clearly left to right.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Apr 7, 2013
1 parent 67d2a7b commit 39a570f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion http.c
Original file line number Diff line number Diff line change
Expand Up @@ -943,7 +943,7 @@ static int http_get_file(const char *url, const char *filename, int options)

void http_error(const char *url)
{
error("%s while accessing %s", curl_errorstr, url);
error("unable to access '%s': %s", url, curl_errorstr);
}

int http_fetch_ref(const char *base, struct ref *ref)
Expand Down

0 comments on commit 39a570f

Please sign in to comment.