Skip to content

Commit

Permalink
rev-list: allow -n<n> as shorthand for --max-count=<n>
Browse files Browse the repository at this point in the history
Both -n<n> and -n <n> are supported.  POSIX versions of head(1) and
tail(1) allow their line limits to be parsed this way.  I find
--max-count to be a commonly used option, and also similar in spirit to
head/tail, so I decided to make life easier on my worn out (and lazy :)
fingers with this patch.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Eric Wong authored and Junio C Hamano committed Feb 1, 2006
1 parent e36f8b6 commit 3af0698
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 0 deletions.
10 changes: 10 additions & 0 deletions rev-list.c
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,16 @@ int main(int argc, const char **argv)
struct commit *commit;
unsigned char sha1[20];

if (!strcmp(arg, "-n")) {
if (++i >= argc)
die("-n requires an argument");
max_count = atoi(argv[i]);
continue;
}
if (!strncmp(arg,"-n",2)) {
max_count = atoi(arg + 2);
continue;
}
if (!strncmp(arg, "--max-count=", 12)) {
max_count = atoi(arg + 12);
continue;
Expand Down
15 changes: 15 additions & 0 deletions rev-parse.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,21 @@ int main(int argc, char **argv)
show_file(arg);
continue;
}
if (!strcmp(arg,"-n")) {
if (++i >= argc)
die("-n requires an argument");
if ((filter & DO_FLAGS) && (filter & DO_REVS)) {
show(arg);
show(argv[i]);
}
continue;
}
if (!strncmp(arg,"-n",2)) {
if ((filter & DO_FLAGS) && (filter & DO_REVS))
show(arg);
continue;
}

if (*arg == '-') {
if (!strcmp(arg, "--")) {
as_is = 1;
Expand Down

0 comments on commit 3af0698

Please sign in to comment.