Skip to content

Commit

Permalink
t9120: don't expect failure with SVN_HTTPD_PORT unset
Browse files Browse the repository at this point in the history
The test still passes when SVN_HTTPD_PORT is not set. Futhermore, t9115
and t9118 don't check if SVN_HTTPD_PORT is set even though they both use
start_httpd() from lib-git-svn.sh. Admittedly, the test is not very
meaningful without SVN_HTTPD_PORT, as commit f5530b (support for funky
branch and project names over HTTP(S) 2007-11-11) states that the URI
escaping is only done over HTTP(S).

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Stephen Boyd authored and Junio C Hamano committed May 29, 2009
1 parent a9d2903 commit 3be7e06
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions t/t9120-git-svn-clone-with-percent-escapes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,12 @@ test_expect_success 'setup svnrepo' '
start_httpd
'

if test "$SVN_HTTPD_PORT" = ""
then
test_expect_failure 'test clone with percent escapes - needs SVN_HTTPD_PORT set' 'false'
else
test_expect_success 'test clone with percent escapes' '
git svn clone "$svnrepo/pr%20ject" clone &&
cd clone &&
git rev-parse refs/${remotes_git_svn} &&
cd ..
'
fi
test_expect_success 'test clone with percent escapes' '
git svn clone "$svnrepo/pr%20ject" clone &&
cd clone &&
git rev-parse refs/${remotes_git_svn} &&
cd ..
'

stop_httpd

Expand Down

0 comments on commit 3be7e06

Please sign in to comment.