Skip to content

Commit

Permalink
use write_str_in_full helper to avoid literal string lengths
Browse files Browse the repository at this point in the history
This is the same fix to use write_str_in_full() helper to write a constant
string out without counting the length of it ourselves.

Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jim Meyering authored and Junio C Hamano committed Sep 13, 2009
1 parent cd03eeb commit 3d91352
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions transport-helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@ static struct child_process *get_helper(struct transport *transport)
die("Unable to run helper: git %s", helper->argv[0]);
data->helper = helper;

strbuf_addstr(&buf, "capabilities\n");
write_in_full(helper->in, buf.buf, buf.len);
strbuf_reset(&buf);
write_str_in_full(helper->in, "capabilities\n");

file = fdopen(helper->out, "r");
while (1) {
Expand All @@ -58,7 +56,7 @@ static int disconnect_helper(struct transport *transport)
{
struct helper_data *data = transport->data;
if (data->helper) {
write_in_full(data->helper->in, "\n", 1);
write_str_in_full(data->helper->in, "\n");
close(data->helper->in);
finish_command(data->helper);
free((char *)data->helper->argv[0]);
Expand Down Expand Up @@ -124,9 +122,7 @@ static struct ref *get_refs_list(struct transport *transport, int for_push)

helper = get_helper(transport);

strbuf_addstr(&buf, "list\n");
write_in_full(helper->in, buf.buf, buf.len);
strbuf_reset(&buf);
write_str_in_full(helper->in, "list\n");

file = fdopen(helper->out, "r");
while (1) {
Expand Down

0 comments on commit 3d91352

Please sign in to comment.