Skip to content

Commit

Permalink
t5516: remove ambiguity test (1)
Browse files Browse the repository at this point in the history
This test tried to push into a remote with ambiguous refs in
remotes/$x/master and remotes/$y/master. However, the remote
never actually tells us about the refs/remotes hierarchy, so
we don't even see this ambiguity.

The test happened to pass because we were simply looking for
failure, and the test fails for another reason: the dst
refspec does not exist and does not begin with refs/, making
it invalid.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Apr 23, 2008
1 parent 837f3b7 commit 3ef6a1f
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions t/t5516-fetch-push.sh
Original file line number Diff line number Diff line change
Expand Up @@ -178,19 +178,7 @@ test_expect_success 'push with weak ambiguity (2)' '
'

test_expect_success 'push with ambiguity (1)' '
mk_test remotes/origin/master remotes/frotz/master &&
if git push testrepo master:master
then
echo "Oops, should have failed"
false
else
check_push_result $the_first_commit remotes/origin/master remotes/frotz/master
fi
'

test_expect_success 'push with ambiguity (2)' '
test_expect_success 'push with ambiguity' '
mk_test heads/frotz tags/frotz &&
if git push testrepo master:frotz
Expand Down

0 comments on commit 3ef6a1f

Please sign in to comment.