Skip to content

Commit

Permalink
mergetool--lib: specialize diff options for emerge and ecmerge
Browse files Browse the repository at this point in the history
The ecmerge documentation mentions the following form:

	ecmerge --mode=diff2 $1 $2

Since git-difftool is about diffing, we should use that instead
of --mode=merge2.  Likewise, this drops the $MERGED argument to
emerge, as discussed on the git list ($gmane/117930).

Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
David Aguilar authored and Junio C Hamano committed May 9, 2009
1 parent f01f109 commit 4481ff0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions git-mergetool--lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ run_merge_tool () {
fi
check_unchanged
else
"$merge_tool_path" "$LOCAL" "$REMOTE" \
--default --mode=merge2 --to="$MERGED"
"$merge_tool_path" --default --mode=diff2 \
"$LOCAL" "$REMOTE"
fi
;;
emerge)
Expand All @@ -248,7 +248,7 @@ run_merge_tool () {
status=$?
else
"$merge_tool_path" -f emerge-files-command \
"$LOCAL" "$REMOTE" "$(basename "$MERGED")"
"$LOCAL" "$REMOTE"
fi
;;
tortoisemerge)
Expand Down

0 comments on commit 4481ff0

Please sign in to comment.