Skip to content

Commit

Permalink
Merge branch 'maint'
Browse files Browse the repository at this point in the history
* maint:
  ignore duplicated slashes in make_relative_path()
  • Loading branch information
Junio C Hamano committed Jan 23, 2010
2 parents 630724c + 288123f commit 459a188
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 9 deletions.
39 changes: 30 additions & 9 deletions path.c
Original file line number Diff line number Diff line change
Expand Up @@ -394,17 +394,38 @@ int set_shared_perm(const char *path, int mode)
const char *make_relative_path(const char *abs, const char *base)
{
static char buf[PATH_MAX + 1];
int baselen;
if (!base)
return abs;
baselen = strlen(base);
if (prefixcmp(abs, base))
int i = 0, j = 0;

if (!base || !base[0])
return abs;
if (abs[baselen] == '/')
baselen++;
else if (base[baselen - 1] != '/')
while (base[i]) {
if (is_dir_sep(base[i])) {
if (!is_dir_sep(abs[j]))
return abs;
while (is_dir_sep(base[i]))
i++;
while (is_dir_sep(abs[j]))
j++;
continue;
} else if (abs[j] != base[i]) {
return abs;
}
i++;
j++;
}
if (
/* "/foo" is a prefix of "/foo" */
abs[j] &&
/* "/foo" is not a prefix of "/foobar" */
!is_dir_sep(base[i-1]) && !is_dir_sep(abs[j])
)
return abs;
strcpy(buf, abs + baselen);
while (is_dir_sep(abs[j]))
j++;
if (!abs[j])
strcpy(buf, ".");
else
strcpy(buf, abs + j);
return buf;
}

Expand Down
6 changes: 6 additions & 0 deletions t/t1501-worktree.sh
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,10 @@ test_expect_success 'absolute pathspec should fail gracefully' '
)
'

test_expect_success 'make_relative_path handles double slashes in GIT_DIR' '
: > dummy_file
echo git --git-dir="$(pwd)//repo.git" --work-tree="$(pwd)" add dummy_file &&
git --git-dir="$(pwd)//repo.git" --work-tree="$(pwd)" add dummy_file
'

test_done

0 comments on commit 459a188

Please sign in to comment.