Skip to content

Commit

Permalink
filter-branch: update current branch when rewritten
Browse files Browse the repository at this point in the history
Earlier, "git filter-branch --<options> HEAD" would not update the
working tree after rewriting the branch.  This commit fixes it.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
Johannes Schindelin authored and Shawn O. Pearce committed Oct 17, 2007
1 parent 8ef4451 commit 46eb449
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
15 changes: 15 additions & 0 deletions git-filter-branch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ USAGE="[--env-filter <command>] [--tree-filter <command>] \

. git-sh-setup

git diff-files --quiet &&
git diff-index --cached --quiet HEAD ||
die "Cannot rewrite branch(es) with a dirty working directory."

tempdir=.git-rewrite
filter_env=
filter_tree=
Expand Down Expand Up @@ -196,6 +200,9 @@ do
esac
done < "$tempdir"/backup-refs

ORIG_GIT_DIR="$GIT_DIR"
ORIG_GIT_WORK_TREE="$GIT_WORK_TREE"
ORIG_GIT_INDEX_FILE="$GIT_INDEX_FILE"
export GIT_DIR GIT_WORK_TREE=.

# These refs should be updated if their heads were rewritten
Expand Down Expand Up @@ -413,4 +420,12 @@ echo
test $count -gt 0 && echo "These refs were rewritten:"
git show-ref | grep ^"$orig_namespace"

unset GIT_DIR GIT_WORK_TREE GIT_INDEX_FILE
test -z "$ORIG_GIT_DIR" || GIT_DIR="$ORIG_GIT_DIR" && export GIT_DIR
test -z "$ORIG_GIT_WORK_TREE" || GIT_WORK_TREE="$ORIG_GIT_WORK_TREE" &&
export GIT_WORK_TREE
test -z "$ORIG_GIT_INDEX_FILE" || GIT_INDEX_FILE="$ORIG_GIT_INDEX_FILE" &&
export GIT_INDEX_FILE
git read-tree -u -m HEAD

exit $ret
4 changes: 3 additions & 1 deletion t/t7003-filter-branch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ test_expect_success 'rewrite, renaming a specific file' '
'

test_expect_success 'test that the file was renamed' '
test d = $(git show HEAD:doh)
test d = $(git show HEAD:doh) &&
test -f doh &&
test d = $(cat doh)
'

git tag oldD HEAD~4
Expand Down

0 comments on commit 46eb449

Please sign in to comment.