Skip to content

Commit

Permalink
gitk: Avoid crash if closed while reading references
Browse files Browse the repository at this point in the history
As recorded in msysGit issue 125, if the user closes gitk while it
reports itself as still reading references then Tk will crash in the
geometry management code.  This has been fixed for Tk 8.5.7 and above.
This patch avoids the problem by flushing outstanding geometry events
before calling the readrefs procedure.

See also http://code.google.com/p/msysgit/issues/detail?id=125

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Pat Thoyts authored and Paul Mackerras committed Apr 17, 2009
1 parent b575b2f commit 478afad
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions gitk
Original file line number Diff line number Diff line change
Expand Up @@ -11128,6 +11128,7 @@ catch {
# wait for the window to become visible
tkwait visibility .
wm title . "[file tail $argv0]: [file tail [pwd]]"
update
readrefs

if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {
Expand Down

0 comments on commit 478afad

Please sign in to comment.