Skip to content

Commit

Permalink
MinGW: truncate exit()'s argument to lowest 8 bits
Browse files Browse the repository at this point in the history
For some reason, MinGW's bash cannot reliably detect failure of the child
process if a negative value is passed to exit(). This fixes it by
truncating the exit code in all calls of exit().

This issue was worked around in run_builtin() of git.c (2488df8 builtin
run_command: do not exit with -1, 2007-11-15). This workaround is no longer
necessary and is reverted.

Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Johannes Sixt authored and Junio C Hamano committed Jul 5, 2009
1 parent 606475f commit 47e3de0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions compat/mingw.h
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ static inline int fcntl(int fd, int cmd, long arg)
errno = EINVAL;
return -1;
}
/* bash cannot reliably detect negative return codes as failure */
#define exit(code) exit((code) & 0xff)

/*
* simple adaptors
Expand Down
2 changes: 1 addition & 1 deletion git.c
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)

status = p->fn(argc, argv, prefix);
if (status)
return status & 0xff;
return status;

/* Somebody closed stdout? */
if (fstat(fileno(stdout), &st))
Expand Down

0 comments on commit 47e3de0

Please sign in to comment.