Skip to content

Commit

Permalink
git rebase --abort: always restore the right commit
Browse files Browse the repository at this point in the history
Previously, --abort would end by git resetting to ORIG_HEAD, but some
commands, such as git reset --hard (which happened in git rebase --skip,
but could just as well be typed by the user), would have already modified
ORIG_HEAD.

Just use the orig-head we store in $dotest instead.

Signed-off-by: Mike Hommey <mh@glandium.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Mike Hommey authored and Junio C Hamano committed Mar 2, 2008
1 parent f32086b commit 48411d2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions git-rebase.sh
Original file line number Diff line number Diff line change
Expand Up @@ -208,16 +208,15 @@ do
if test -d "$dotest"
then
move_to_original_branch
rm -r "$dotest"
elif test -d .dotest
then
dotest=.dotest
move_to_original_branch
rm -r .dotest
else
die "No rebase in progress?"
fi
git reset --hard ORIG_HEAD
git reset --hard $(cat $dotest/orig-head)
rm -r "$dotest"
exit
;;
--onto)
Expand Down
2 changes: 1 addition & 1 deletion t/t3407-rebase-abort.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ test_expect_success 'rebase --abort' '
test $(git rev-parse to-rebase) = $(git rev-parse pre-rebase)
'

test_expect_failure 'rebase --abort after --skip' '
test_expect_success 'rebase --abort after --skip' '
# Clean up the state from the previous one
git reset --hard pre-rebase
rm -rf .dotest
Expand Down

0 comments on commit 48411d2

Please sign in to comment.