Skip to content

Commit

Permalink
rebase: make -v a tiny bit more verbose
Browse files Browse the repository at this point in the history
To make it possible to later remove the handling of --abort from
git-rebase--interactive.sh, align the implementation in git-rebase.sh
with the former by making it a bit more verbose.

Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Martin von Zweigbergk authored and Junio C Hamano committed Feb 10, 2011
1 parent 431b7e7 commit 4974c2c
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
14 changes: 0 additions & 14 deletions git-rebase--interactive.sh
Original file line number Diff line number Diff line change
Expand Up @@ -86,20 +86,6 @@ warn () {
printf '%s\n' "$*" >&2
}

output () {
case "$verbose" in
'')
output=$("$@" 2>&1 )
status=$?
test $status != 0 && printf "%s\n" "$output"
return $status
;;
*)
"$@"
;;
esac
}

# Output the commit message for the specified commit.
commit_message () {
git cat-file commit "$1" | sed "1,/^$/d"
Expand Down
18 changes: 16 additions & 2 deletions git-rebase.sh
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,20 @@ read_basic_state () {
GIT_QUIET=$(cat "$state_dir"/quiet)
}

output () {
case "$verbose" in
'')
output=$("$@" 2>&1 )
status=$?
test $status != 0 && printf "%s\n" "$output"
return $status
;;
*)
"$@"
;;
esac
}

move_to_original_branch () {
case "$head_name" in
refs/*)
Expand Down Expand Up @@ -263,7 +277,7 @@ continue)
run_specific_rebase
;;
skip)
git reset --hard HEAD || exit $?
output git reset --hard HEAD || exit $?
read_basic_state
run_specific_rebase
;;
Expand All @@ -276,7 +290,7 @@ abort)
die "Could not move back to $head_name"
;;
esac
git reset --hard $orig_head
output git reset --hard $orig_head
rm -r "$state_dir"
exit
;;
Expand Down

0 comments on commit 4974c2c

Please sign in to comment.