Skip to content

Commit

Permalink
Allow an alias to start with "-p"
Browse files Browse the repository at this point in the history
Now, something like

	[alias]
		pd = -p diff

works as expected.

[jc: a follow-up fix from Jeff King folded in.]

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Johannes Schindelin authored and Junio C Hamano committed Jul 25, 2006
1 parent 96256bb commit 4ab243a
Showing 1 changed file with 30 additions and 6 deletions.
36 changes: 30 additions & 6 deletions git.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,27 @@ static void prepend_to_path(const char *dir, int len)
setenv("PATH", path, 1);
}

static int handle_options(const char*** argv, int* argc)
{
int handled = 0;

while (*argc > 0) {
const char *cmd = (*argv)[0];
if (cmd[0] != '-')
break;

if (!strcmp(cmd, "-p") || !strcmp(cmd, "--paginate")) {
setup_pager();
} else
die ("Unknown option: %s", cmd);

(*argv)++;
(*argc)--;
handled++;
}
return handled;
}

static const char *alias_command;
static char *alias_string = NULL;

Expand Down Expand Up @@ -106,14 +127,18 @@ static int handle_alias(int *argcp, const char ***argv)

subdir = setup_git_directory_gently(&nongit);
if (!nongit) {
int count;
int count, option_count;
const char** new_argv;

alias_command = (*argv)[0];
git_config(git_alias_config);
if (alias_string) {

count = split_cmdline(alias_string, &new_argv);
option_count = handle_options(&new_argv, &count);
memmove(new_argv - option_count, new_argv,
count * sizeof(char *));
new_argv -= option_count;

if (count < 1)
die("empty alias for %s", alias_command);
Expand Down Expand Up @@ -273,13 +298,12 @@ int main(int argc, const char **argv, char **envp)

/* Look for flags.. */
while (argc > 1) {
cmd = *++argv;
argv++;
argc--;

if (!strcmp(cmd, "-p") || !strcmp(cmd, "--paginate")) {
setup_pager();
continue;
}
handle_options(&argv, &argc);

cmd = *argv;

if (strncmp(cmd, "--", 2))
break;
Expand Down

0 comments on commit 4ab243a

Please sign in to comment.