Skip to content

Commit

Permalink
gitk: Make text selectable on Mac
Browse files Browse the repository at this point in the history
Stolen from git-gui, 23effa7 (original log message by
Shawn O. Pearce <spearce@spearce.org> follows):

    git-gui: Force focus to the diff viewer on mouse click.

    Apparently a "feature" of Tcl/Tk on Mac OS X is that a disabled text
    widget cannot receive focus or receive a selection within it.  This
    makes the diff viewer almost useless on that platform as you cannot
    select individual parts of the buffer.

    Now we force focus into the diff viewer when its clicked on with
    button 1.  This works around the feature and allows selection to
    work within the viewer just like it does on other less sane systems,
    like Microsoft Windows.

Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Stefan Haller authored and Paul Mackerras committed Dec 12, 2010
1 parent 120ea89 commit 4adcbea
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions gitk
Original file line number Diff line number Diff line change
Expand Up @@ -2477,6 +2477,7 @@ proc makewindow {} {
global ctxbut
bind $cflist $ctxbut {pop_flist_menu %W %X %Y %x %y}
bind $ctext $ctxbut {pop_diff_menu %W %X %Y %x %y}
bind $ctext <Button-1> {focus %W}

set maincursor [. cget -cursor]
set textcursor [$ctext cget -cursor]
Expand Down

0 comments on commit 4adcbea

Please sign in to comment.