Skip to content

Commit

Permalink
i18n.logToUTF8: convert commit log message to UTF-8
Browse files Browse the repository at this point in the history
When i18n.commitencoding is set to a non UTF-8 encoding,
commit-tree records the encoding in an extra header after
author/committer headers in the commit object.

An earlier version used trailer but Johannes points out that
there is little risk breaking existing Porcelains with a new
header.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed Dec 26, 2006
1 parent b45974a commit 4b2bced
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions builtin-commit-tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)
char comment[1000];
char *buffer;
unsigned int size;
int encoding_is_utf8;

setup_ident();
git_config(git_default_config);
Expand All @@ -117,6 +118,8 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)
parents++;
}

encoding_is_utf8 = !strcmp(git_commit_encoding, "utf-8");

init_buffer(&buffer, &size);
add_buffer(&buffer, &size, "tree %s\n", sha1_to_hex(tree_sha1));

Expand All @@ -130,15 +133,19 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)

/* Person/date information */
add_buffer(&buffer, &size, "author %s\n", git_author_info(1));
add_buffer(&buffer, &size, "committer %s\n\n", git_committer_info(1));
add_buffer(&buffer, &size, "committer %s\n", git_committer_info(1));
if (!encoding_is_utf8)
add_buffer(&buffer, &size,
"encoding %s\n", git_commit_encoding);
add_buffer(&buffer, &size, "\n");

/* And add the comment */
while (fgets(comment, sizeof(comment), stdin) != NULL)
add_buffer(&buffer, &size, "%s", comment);

/* And check the encoding */
buffer[size] = '\0';
if (!strcmp(git_commit_encoding, "utf-8") && !is_utf8(buffer))
if (encoding_is_utf8 && !is_utf8(buffer))
fprintf(stderr, commit_utf8_warn);

if (!write_sha1_file(buffer, size, commit_type, commit_sha1)) {
Expand Down

0 comments on commit 4b2bced

Please sign in to comment.