Skip to content

Commit

Permalink
blame: -b (blame.blankboundary) and --root (blame.showroot)
Browse files Browse the repository at this point in the history
When blame.blankboundary is set (or -b option is given), commit
object names are blanked out in the "human readable" output
format for boundary commits.

When blame.showroot is not set (or --root is not given), the
root commits are treated as boundary commits.  The code still
attributes the lines to them, but with -b their object names are
not shown.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed Dec 19, 2006
1 parent 8336afa commit 4c10a5c
Showing 1 changed file with 31 additions and 2 deletions.
33 changes: 31 additions & 2 deletions builtin-blame.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
static char blame_usage[] =
"git-blame [-c] [-l] [-t] [-f] [-n] [-p] [-L n,m] [-S <revs-file>] [-M] [-C] [-C] [commit] [--] file\n"
" -c, --compatibility Use the same output mode as git-annotate (Default: off)\n"
" -b Show blank SHA-1 for boundary commits (Default: off)\n"
" -l, --long Show long commit SHA1 (Default: off)\n"
" --root Do not treat root commits as boundaries (Default: off)\n"
" -t, --time Show raw timestamp (Default: off)\n"
" -f, --show-name Show original filename (Default: auto)\n"
" -n, --show-number Show original linenumber (Default: off)\n"
Expand All @@ -36,6 +38,8 @@ static int longest_author;
static int max_orig_digits;
static int max_digits;
static int max_score_digits;
static int show_root;
static int blank_boundary;

#ifndef DEBUG
#define DEBUG 0
Expand Down Expand Up @@ -1095,6 +1099,9 @@ static void assign_blame(struct scoreboard *sb, struct rev_info *revs, int opt)
if (commit->object.parsed)
mark_parents_uninteresting(commit);
}
/* treat root commit as boundary */
if (!commit->parents && !show_root)
commit->object.flags |= UNINTERESTING;

/* Take responsibility for the remaining entries */
for (ent = sb->ent; ent; ent = ent->next)
Expand Down Expand Up @@ -1318,8 +1325,12 @@ static void emit_other(struct scoreboard *sb, struct blame_entry *ent, int opt)
int length = (opt & OUTPUT_LONG_OBJECT_NAME) ? 40 : 8;

if (suspect->commit->object.flags & UNINTERESTING) {
length--;
putchar('^');
if (!blank_boundary) {
length--;
putchar('^');
}
else
memset(hex, ' ', length);
}

printf("%.*s", length, hex);
Expand Down Expand Up @@ -1639,6 +1650,19 @@ static void prepare_blame_range(struct scoreboard *sb,
usage(blame_usage);
}

static int git_blame_config(const char *var, const char *value)
{
if (!strcmp(var, "blame.showroot")) {
show_root = git_config_bool(var, value);
return 0;
}
if (!strcmp(var, "blame.blankboundary")) {
blank_boundary = git_config_bool(var, value);
return 0;
}
return git_default_config(var, value);
}

int cmd_blame(int argc, const char **argv, const char *prefix)
{
struct rev_info revs;
Expand All @@ -1654,6 +1678,7 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
char type[10];
const char *bottomtop = NULL;

git_config(git_blame_config);
save_commit_buffer = 0;

opt = 0;
Expand All @@ -1662,6 +1687,10 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
const char *arg = argv[i];
if (*arg != '-')
break;
else if (!strcmp("-b", arg))
blank_boundary = 1;
else if (!strcmp("--root", arg))
show_root = 1;
else if (!strcmp("-c", arg))
output_option |= OUTPUT_ANNOTATE_COMPAT;
else if (!strcmp("-t", arg))
Expand Down

0 comments on commit 4c10a5c

Please sign in to comment.