Skip to content

Commit

Permalink
t7810-*.sh: Remove redundant test
Browse files Browse the repository at this point in the history
Since commit bbc09c2 ("grep: rip out support for external grep",
12-01-2010), test number 60 ("grep -C1 hunk mark between files") is
essentially the same as test number 59.

Test 59 was intended to verify the behaviour of git-grep resulting
from multiple invocations of an external grep. As part of the test,
it creates and adds 1024 files to the index, which is now wasted
effort.

Remove test 59, since it is now redundant.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ramsay Jones authored and Junio C Hamano committed Jul 30, 2012
1 parent d0f1ea6 commit 4ca9453
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions t/t7810-grep.sh
Original file line number Diff line number Diff line change
Expand Up @@ -387,17 +387,6 @@ test_expect_success 'grep -q, silently report matches' '
test_cmp empty actual
'

# Create 1024 file names that sort between "y" and "z" to make sure
# the two files are handled by different calls to an external grep.
# This depends on MAXARGS in builtin-grep.c being 1024 or less.
c32="0 1 2 3 4 5 6 7 8 9 a b c d e f g h i j k l m n o p q r s t u v"
test_expect_success 'grep -C1, hunk mark between files' '
for a in $c32; do for b in $c32; do : >y-$a$b; done; done &&
git add y-?? &&
git grep -C1 "^[yz]" >actual &&
test_cmp expected actual
'

test_expect_success 'grep -C1 hunk mark between files' '
git grep -C1 "^[yz]" >actual &&
test_cmp expected actual
Expand Down

0 comments on commit 4ca9453

Please sign in to comment.