Skip to content

Commit

Permalink
Merge branch 'pt/pull-log-n' into maint
Browse files Browse the repository at this point in the history
"git pull --log" and "git pull --no-log" worked as expected, but
"git pull --log=20" did not.

* pt/pull-log-n:
  pull: handle --log=<n>
  • Loading branch information
Junio C Hamano committed Jun 5, 2015
2 parents 7e46f27 + 5061a44 commit 4cb9fe3
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
4 changes: 2 additions & 2 deletions git-pull.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ do
diffstat=--no-stat ;;
--stat|--summary)
diffstat=--stat ;;
--log|--no-log)
log_arg=$1 ;;
--log|--log=*|--no-log)
log_arg="$1" ;;
--no-c|--no-co|--no-com|--no-comm|--no-commi|--no-commit)
no_commit=--no-commit ;;
--c|--co|--com|--comm|--commi|--commit)
Expand Down
17 changes: 17 additions & 0 deletions t/t5524-pull-msg.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ test_expect_success setup '
git commit -m "add bfile"
) &&
test_tick && test_tick &&
echo "second" >afile &&
git add afile &&
git commit -m "second commit" &&
echo "original $dollar" >afile &&
git add afile &&
git commit -m "do not clobber $dollar signs"
Expand All @@ -32,4 +35,18 @@ test_expect_success pull '
)
'

test_expect_success '--log=1 limits shortlog length' '
(
cd cloned &&
git reset --hard HEAD^ &&
test "$(cat afile)" = original &&
test "$(cat bfile)" = added &&
git pull --log=1 &&
git log -3 &&
git cat-file commit HEAD >result &&
grep Dollar result &&
! grep "second commit" result
)
'

test_done

0 comments on commit 4cb9fe3

Please sign in to comment.