Skip to content

Commit

Permalink
Simplify setup of $GIT_DIR in git-sh-setup.sh
Browse files Browse the repository at this point in the history
Using 'git rev-parse --git-dir' makes the code shorter and more future-
proof.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Lars Hjemli authored and Junio C Hamano committed Feb 19, 2008
1 parent ee4f06c commit 4d6d6d2
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions git-sh-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -127,20 +127,14 @@ get_author_ident_from_commit () {
# if we require to be in a git repository.
if test -z "$NONGIT_OK"
then
GIT_DIR=$(git rev-parse --git-dir) || exit
if [ -z "$SUBDIRECTORY_OK" ]
then
: ${GIT_DIR=.git}
test -z "$(git rev-parse --show-cdup)" || {
exit=$?
echo >&2 "You need to run this command from the toplevel of the working tree."
exit $exit
}
else
GIT_DIR=$(git rev-parse --git-dir) || {
exit=$?
echo >&2 "Failed to find a valid git directory."
exit $exit
}
fi
test -n "$GIT_DIR" && GIT_DIR=$(cd "$GIT_DIR" && pwd) || {
echo >&2 "Unable to determine absolute path of git directory"
Expand Down

0 comments on commit 4d6d6d2

Please sign in to comment.