Skip to content

Commit

Permalink
http: drop http_error function
Browse files Browse the repository at this point in the history
This function is a single-liner and is only called from one
place. Just inline it, which makes the code more obvious.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Apr 7, 2013
1 parent de89f0b commit 4df13f6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion http-push.c
Original file line number Diff line number Diff line change
Expand Up @@ -1551,7 +1551,7 @@ static int remote_exists(const char *path)
ret = 0;
break;
case HTTP_ERROR:
http_error(url);
error("unable to access '%s': %s", url, curl_errorstr);
default:
ret = -1;
}
Expand Down
5 changes: 0 additions & 5 deletions http.c
Original file line number Diff line number Diff line change
Expand Up @@ -941,11 +941,6 @@ static int http_get_file(const char *url, const char *filename, int options)
return ret;
}

void http_error(const char *url)
{
error("unable to access '%s': %s", url, curl_errorstr);
}

int http_fetch_ref(const char *base, struct ref *ref)
{
char *url;
Expand Down
5 changes: 0 additions & 5 deletions http.h
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,6 @@ extern char *get_remote_object_url(const char *url, const char *hex,
*/
int http_get_strbuf(const char *url, struct strbuf *content_type, struct strbuf *result, int options);

/*
* Prints an error message using error() containing url and curl_errorstr.
*/
void http_error(const char *url);

extern int http_fetch_ref(const char *base, struct ref *ref);

/* Helpers for fetching packs */
Expand Down

0 comments on commit 4df13f6

Please sign in to comment.