Skip to content

Commit

Permalink
bisect view: check for MinGW32 and MacOSX in addition to X11
Browse files Browse the repository at this point in the history
When deciding if gitk or git-log should be used to visualize the current
state, the environment variable DISPLAY was checked.  Now, we check
MSYSTEM (for MinGW32/MSys) and SECURITYSESSIONID (for MacOSX) in addition.

Note that there is currently no way to ssh into MinGW32, and that
SECURITYSESSIONID is not set automatically on MacOSX when ssh'ing into it.
So this patch should be safe.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Johannes Schindelin authored and Junio C Hamano committed Feb 18, 2008
1 parent 61b8050 commit 508e84a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions git-bisect.sh
Original file line number Diff line number Diff line change
Expand Up @@ -331,9 +331,9 @@ bisect_visualize() {

if test $# = 0
then
case "${DISPLAY+set}" in
case "${DISPLAY+set}${MSYSTEM+set}${SECURITYSESSIONID+set}" in
'') set git log ;;
set) set gitk ;;
set*) set gitk ;;
esac
else
case "$1" in
Expand Down

0 comments on commit 508e84a

Please sign in to comment.