Skip to content

Commit

Permalink
git.c: remove unnecessary #includes
Browse files Browse the repository at this point in the history
"cache.h" and "commit.h" are already included via "builtin.h".

We started to include "quote.h" at 575ba9d (GIT_TRACE: show which
built-in/external commands are executed, 2006-06-25) that wanted to
use sq_quote_print().

When 6ce4e61 (Trace into a file or an open fd and refactor tracing
code., 2006-09-02) introduced trace.c API, the calls this file makes
to sq_quote_print() were replaced by calls to trace_argv_printf()
that are declared in "cache.h", which this file already includes.
We should have stopped including "quote.h" in that commit, but
forgot to do so.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Alexander Kuleshov authored and Junio C Hamano committed Jan 10, 2015
1 parent 7ba4626 commit 50fea42
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions git.c
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
#include "builtin.h"
#include "cache.h"
#include "exec_cmd.h"
#include "help.h"
#include "quote.h"
#include "run-command.h"
#include "commit.h"

const char git_usage_string[] =
"git [--version] [--help] [-C <path>] [-c name=value]\n"
Expand Down

0 comments on commit 50fea42

Please sign in to comment.